Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RTD flyout positioning on mobile by making the sidebar have a fixed bottom position #243

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

Cadair
Copy link
Member

@Cadair Cadair commented Mar 27, 2024

This is the worst, I am remote debugging on mobile when I have to have the test builds on rtd.

Also fixes #240

@Cadair Cadair marked this pull request as ready for review March 27, 2024 13:26
@Cadair Cadair changed the title Attempting to fix rtd on mobile Fix RTD flyout positioning on mobile by making the sidebar have a fixed bottom position Mar 27, 2024
@nabobalis
Copy link
Contributor

Is this an our problem or an upstream problem?

Copy link
Contributor

@nabobalis nabobalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks like sane changes to me. I've not tested it as I'm on my phone

@Cadair
Copy link
Member Author

Cadair commented Mar 27, 2024

Is this an our problem or an upstream problem?

It's our problem introduced by fixing the top nav.

@Cadair Cadair merged commit 47e50f3 into sunpy:main Mar 27, 2024
8 checks passed
@Cadair Cadair deleted the more_rtd_mobile branch March 27, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RTD Version picker does not automatically scroll up on mobile
3 participants