-
-
Notifications
You must be signed in to change notification settings - Fork 54
NDCube.fill_masked() method #829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
8bb8e9f
New PR, copied ndcube.py from the other branch nddataArithmetic.
PCJY 4e5dcd0
Changed the code to be consistent with main/ndcube.py instead.
PCJY 4ffb573
Implementing NDCube.fill().
PCJY fb36c80
Added changelog, implementing NDCube.fill().
PCJY e1919fa
Added changelog again
PCJY b06a1cc
If fill_in_place is False, then return kwargs.
PCJY 73cb945
Update changelog/829.feature.rst
PCJY 1715862
Update ndcube/ndcube.py
PCJY 20945f2
Update ndcube/ndcube.py
PCJY 157f4b3
Update ndcube/ndcube.py
PCJY 41d3b24
Update ndcube/ndcube.py
PCJY 1afe30a
Update ndcube/ndcube.py
PCJY f280941
Update ndcube/ndcube.py
PCJY fb00430
Update ndcube/ndcube.py
PCJY eb3d0e8
Update ndcube/ndcube.py
PCJY bad2a26
Implementing the fill_masked method.
PCJY 0cd0e60
Merge branch 'main' of https://github.com/sunpy/ndcube into NDCubefill
PCJY 468fcb2
About units.
PCJY a35feeb
Further implementing, preparing for testing.
PCJY 0cbfbd7
Added test for the fill_masked method.
PCJY 0d4055f
Fixed error about docstring.
PCJY be4639a
Changed the docstring again.
PCJY 74c648e
Update ndcube/ndcube.py
PCJY b7e99bd
Update ndcube/conftest.py
PCJY d422668
Update ndcube/ndcube.py
PCJY cc65f5d
Update ndcube/tests/helpers.py
PCJY 75bf81a
deal with unmasking after using self.mask
PCJY be1db6e
Notes from Meeting.
PCJY 68def22
Modified NDCube.fill_masked method and its tests.
PCJY 26811c8
Debugging
PCJY db285ba
Update ndcube/ndcube.py
PCJY 8b6d9bc
Small changes from previous meeting.
PCJY 1f59a44
Changed test arguments.
PCJY c26563a
Fixing bugs in tests.
PCJY c8a86a5
Fixed coverage issue by adding more test cases.
PCJY e60eb24
Exclude defensive assertions from coverage test.
PCJY b7b9f9f
Merge branch 'main' of https://github.com/sunpy/ndcube into NDCubefill
PCJY 4983a54
Update ndcube/tests/helpers.py
PCJY d40e887
Changed code for Single-Bool-True-Mask case.
PCJY 9c7aa14
Change fixture.
PCJY 764dc66
Update ndcube/tests/helpers.py
PCJY 3c8456d
Merge branch 'main' of https://github.com/sunpy/ndcube into NDCubefill
PCJY c85c74a
Merge branch 'NDCubefill' of https://github.com/PCJY/ndcube into NDCu…
PCJY File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Added ``fill`` method to ``NDCube``, a new feature which allows users to replace masked values and uncertainty values with user-given fill values, | ||
to change the mask values back to False or not (Default), and to set whether the new instance is returned (Default) or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.