Add headers and timeout #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabobalis
commented
Jan 30, 2025
nabobalis
force-pushed
the
add_headers
branch
from
f1dbe63 to
e49d7b6
Compare
nabobalis
force-pushed
the
add_headers
branch
from
e30b2dd to
49e86a0
Compare
nabobalis
force-pushed
the
add_headers
branch
from
360bddc to
6a33012
Compare
nabobalis
force-pushed
the
add_headers
branch
from
6a33012 to
e4bc195
Compare
nabobalis
force-pushed
the
add_headers
branch
from
e4bc195 to
c0d7bf4
Compare
nabobalis
force-pushed
the
add_headers
branch
from
ff69de5 to
8370185
Compare
nabobalis
force-pushed
the
add_headers
branch
from
330ebef to
2e70053
Compare
samaloney
reviewed
Feb 5, 2025
Member
samaloney
left a comment
samaloney
left a comment
There was a problem hiding this comment.
The fix itself looks good.
I wonder about the changes to make the tests, examples run, I guess once JSOC is completely back we should revert and make sure the current ones work?
Member
Author
|
Yeah I need to revert the skipped tests in the future to ensure that all still works. |
Cadair
approved these changes
Feb 5, 2025
| >>> export_request = client.export('hmi.v_45s[2016.04.01_TAI/1d@6h]{Dopplergram}') # doctest: +REMOTE_DATA | ||
| >>> export_request # doctest: +REMOTE_DATA | ||
| >>> export_request # doctest: +SKIP |
Member
There was a problem hiding this comment.
Why not just skip the whole file? wouldn't it be easier to revert?
Member
Author
There was a problem hiding this comment.
I wanted to see what was broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53