Registers package with sunpy template #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cadair
reviewed
Sep 12, 2024
Cadair
reviewed
Sep 12, 2024
Co-authored-by: Stuart Mumford <stuart@cadair.com>
Co-authored-by: Stuart Mumford <stuart@cadair.com>
CyclingNinja
force-pushed
the
register_template
branch
from
b2242fc
to
62b2de3
Compare
nabobalis
reviewed
Sep 16, 2024
nabobalis
reviewed
Sep 16, 2024
nabobalis
reviewed
Sep 16, 2024
nabobalis
reviewed
Sep 16, 2024
… register_template
CyclingNinja
force-pushed
the
register_template
branch
from
62b2de3
to
33ef348
Compare
CyclingNinja
force-pushed
the
register_template
branch
2 times, most recently
from
4446c09
to
2a2176d
Compare
CyclingNinja
force-pushed
the
register_template
branch
from
2a2176d
to
279b1f0
Compare
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
|
@nabobalis The online build is failing with some errors in tutorial.rst and I am not sure if they are real errors or just weirdness. |
|
That looks like a real error but I can't imagine it comes from this PR |
nabobalis
reviewed
Oct 16, 2024
|
|
?
|
Also the CI has not run for like 3 months, so it's possible it's just broken and we never knew. |
|
I am not maintaining DRMS, so I leave the review and merge to someone who is. |
|
Well in that case, executive power deployed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.