Skip to content

Commit

Permalink
iso-tp: return if updated (commaai#1610)
Browse files Browse the repository at this point in the history
return if updated

reverts some of commaai#1314
  • Loading branch information
sshane authored Aug 26, 2023
1 parent 01db9e4 commit 0eb04fa
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions python/uds.py
Original file line number Diff line number Diff line change
Expand Up @@ -449,18 +449,18 @@ def recv(self, timeout=None) -> Tuple[Optional[bytes], bool]:
timeout = self.timeout

start_time = time.monotonic()
rx_in_progress = False
updated = False
try:
while True:
for msg in self._can_client.recv():
frame_type = self._isotp_rx_next(msg)
self._isotp_rx_next(msg)
start_time = time.monotonic()
rx_in_progress = frame_type == ISOTP_FRAME_TYPE.CONSECUTIVE
updated = True
if self.tx_done and self.rx_done:
return self.rx_dat, False
return self.rx_dat, updated
# no timeout indicates non-blocking
if timeout == 0:
return None, rx_in_progress
return None, updated
if time.monotonic() - start_time > timeout:
raise MessageTimeoutError("timeout waiting for response")
finally:
Expand Down

0 comments on commit 0eb04fa

Please sign in to comment.