Skip to content

Fix partial block referencing in nested partials #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 10, 2022
Merged

Fix partial block referencing in nested partials #488

merged 3 commits into from
Jan 10, 2022

Conversation

@sunng87
Copy link
Owner

@sunng87 sunng87 commented Jan 9, 2022

Fixes #487

We can only increase patial_block_depth for scenarios where
consecutive @partial-block are rendered.

sunng87 added 2 commits January 7, 2022 23:14
@sunng87
test: add case for #487
bc17d7e
@sunng87
fix: corrected partial_block_depth mechanism
4f3def3 
Fixes #487

We can only increase `patial_block_depth` for scenarios where
consecutive `@partial-block` are rendered.
@sunng87 sunng87 mentioned this pull request Jan 9, 2022
Closed
@sunng87 sunng87 merged commit a93a327 into master Jan 10, 2022
@sunng87 sunng87 deleted the fix/nested-partial-with-partial-block branch January 10, 2022 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nested partials cause stack overflow

2 participants

@sunng87