Run shellcheck against ./script/* (dependabot#5820)

A few more places we can run shellcheck against...
sungam3r · Jan 19, 2023 · 5024751 · 5024751
1 parent bd376f0
commit 5024751
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 3 deletions.
diff --git a/bin/ci-test b/bin/ci-test
@@ -37,8 +37,6 @@ function build() {
   export CORE=dependabot/dependabot-core
   export UPDATER=dependabot/dependabot-updater
 
-  # shellcheck disable=SC2034  # shellcheck isn't smart enough to realize `docker build` uses `TARGETARCH`
-  local TARGETARCH;
   # shellcheck disable=SC2034  # shellcheck isn't smart enough to realize `docker build` uses `TARGETARCH`
   case "$(uname -m)"
   in

diff --git a/bin/lint b/bin/lint
@@ -10,6 +10,8 @@ shellcheck \
   ./*/helpers/*/build \
   ./*/helpers/build \
   ./*/script/* \
+  ./script/* \
+  ./updater/bin/run \
   "$@"
 
 bundle exec rubocop
diff --git a/script/_common b/script/_common
@@ -1,3 +1,4 @@
+# shellcheck shell=bash
 export LOCAL_IMAGE="dependabot/updater:latest"
 export GPR_IMAGE="docker.pkg.github.com/dependabot/dependabot-updater/dependabot-updater"
 
@@ -6,6 +7,7 @@ function docker_build() {
 
   extract_version
 
+  # shellcheck disable=SC2086  # as $DOCKER_BUILD_ARGS relies on word-splitting
   docker build $DOCKER_BUILD_ARGS -f Dockerfile.updater -t "$LOCAL_IMAGE" --build-arg OMNIBUS_VERSION .
 
   # Verify max layers; an AUFS limit that was _crucial_ on Heroku (but not now)

diff --git a/script/setup b/script/setup
@@ -14,5 +14,5 @@ if [ -z "$GPR_TOKEN" ]; then
 fi
 
 # Log into GPR to pull downstream images
-echo $GPR_TOKEN | docker login docker.pkg.github.com -u x --password-stdin
+echo "$GPR_TOKEN" | docker login docker.pkg.github.com -u x --password-stdin
 docker_build