Fix a Metrics/PerceivedComplexity warning

sungam3r · Jun 16, 2023 · 42a6497 · 42a6497
1 parent cb3eaa6
commit 42a6497
Showing 1 changed file with 20 additions and 8 deletions.
diff --git a/common/lib/dependabot/file_updaters/artifact_updater.rb b/common/lib/dependabot/file_updaters/artifact_updater.rb
@@ -49,14 +49,8 @@ def updated_files(base_directory:, only_paths: nil)
             operation = Dependabot::DependencyFile::Operation::UPDATE
             operation = Dependabot::DependencyFile::Operation::DELETE if type == "D"
             operation = Dependabot::DependencyFile::Operation::CREATE if type == "??"
-            encoding = ""
-            encoded_content = File.read(path) unless operation == Dependabot::DependencyFile::Operation::DELETE
-            if binary_file?(path)
-              encoding = Dependabot::DependencyFile::ContentEncoding::BASE64
-              if operation != Dependabot::DependencyFile::Operation::DELETE
-                encoded_content = Base64.encode64(encoded_content)
-              end
-            end
+
+            encoded_content, encoding = get_encoded_file_contents(path, operation)
 
             create_dependency_file(
               name: file_path.to_s,
@@ -75,6 +69,24 @@ def updated_files(base_directory:, only_paths: nil)
 
       attr_reader :repo_contents_path, :target_directory
 
+      def get_encoded_file_contents(path, operation)
+        encoded_content = nil
+        encoding = ""
+
+        return encoded_content, encoding if operation == Dependabot::DependencyFile::Operation::DELETE
+
+        encoded_content = File.read(path)
+
+        if binary_file?(path)
+          encoding = Dependabot::DependencyFile::ContentEncoding::BASE64
+          if operation != Dependabot::DependencyFile::Operation::DELETE
+            encoded_content = Base64.encode64(encoded_content)
+          end
+        end
+
+        [encoded_content, encoding]
+      end
+
       def binary_file?(path)
         return false unless File.exist?(path)