Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error to printed message when plugin fails to open #1196

Merged
merged 2 commits into from
Jan 22, 2023
Merged

Add error to printed message when plugin fails to open #1196

merged 2 commits into from
Jan 22, 2023

Conversation

svc-user
Copy link

When a plugin fails to open, print the error from the open call to aid in debugging why your custom scanner wont work.

@svc-user svc-user requested a review from sundowndev as a code owner January 17, 2023 19:52
sundowndev
sundowndev requested changes Jan 18, 2023
View reviewed changes
Copy link
Owner

@sundowndev sundowndev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR 👍🏻

Could you edit tests as well? Look at scanner_test.go.

@svc-user
Copy link
Author

Thanks for your PR 👍🏻

Could you edit tests as well? Look at scanner_test.go.

I've updated the test to reflect the expected output.

@sundowndev sundowndev merged commit 8d7c622 into sundowndev:master Jan 22, 2023
@sundowndev
Copy link
Owner

Released in v2.10.2

@svc-user svc-user deleted the fix/print-error-on-plugin-fail branch January 22, 2023 11:25
@Denska10
Copy link

Denska10 commented Jul 2, 2023

Error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundowndev sundowndev sundowndev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svc-user @sundowndev @Denska10