Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use API v2 in web client #1153

Merged
merged 24 commits into from
Nov 5, 2022
Merged

Use API v2 in web client #1153

merged 24 commits into from
Nov 5, 2022

Conversation

RomainMaillot
Copy link
Contributor

  • Use v2 of API instead of v1
  • Scanners are link to v2/scanners
  • Propose to run scanner only if dryrun worked and number is valid
  • Display json viewer for all scanners

Copy link
Owner

@sundowndev sundowndev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution 👍🏻

That's good work overall, I left some comments, I also have a few change requests found when testing the UI manually:

  • web/client/package-lock.json shouldn't exist since we're using yarn. Please run yarn to update yarn-lock.json as well
  • when user enters an invalid number, it does nothing. It should show information only

web/client/src/config/index.ts Outdated Show resolved Hide resolved
web/client/src/components/Scanner.vue Outdated Show resolved Hide resolved
web/client/src/components/Scanner.vue Outdated Show resolved Hide resolved
web/client/src/views/Number.vue Outdated Show resolved Hide resolved
web/client/src/views/Scan.vue Outdated Show resolved Hide resolved
web/client/src/views/Scan.vue Outdated Show resolved Hide resolved
web/client/src/views/Scan.vue Outdated Show resolved Hide resolved
web/package-lock.json Outdated Show resolved Hide resolved
@sundowndev sundowndev changed the title Front rework Use API v2 in web client Oct 26, 2022
web/client/src/utils/index.ts Outdated Show resolved Hide resolved
@sundowndev sundowndev merged commit 6d6b173 into sundowndev:master Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants