Merge 0.19.0 of net ldap #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers that don't support it.
…ops to get a Hash.
Base64.encode64 adds \n every 60 encoded chars. This was originally an encoding mechanism for sending binary content in e-mail, where the line length is limited. For passwords we dont want this. cf https://stackoverflow.com/questions/2620975/strange-n-in-base64-encoded-string-in-ruby
Fix ruby-ldap#318 by adding a link to rubydoc.info.
instead of polluting devs machine, let's rely on a docker container to spin up the service relies on osixia/openldap:1.3.0. Customizes a few things: - adds the seed on bootstrap - does not enforce client certificate - sets a hostname to avoid domain verification issues during handshake The cert domain is also added to /etc/hosts
anonymous access is not enabled in this setup, so every test needs to perform authentication first
I couldn't manage to get the container running with a cert issued to a given IP, like 127.0.0.1 or localhost. Instead, I specified a static hostname (the container uses hostname to generate the cert) and injected it in travis. Unfortunately, in local development this means changing /etc/hosts, but I feel that's a better option that having to install LDAP locally
so that all retcode tests succeed
it's a little price to pay in the current setup and allows us to have the same tests locally and dev.
all environments run the same set of tests, no env specific test
so that we are able to run a test that does not specific CACERT and so the library fallsback to system cert store
…g user controls even if the paged and ber_sort flags weren't set
Prepare release v0.18.0
…_values Net::LDAP::DN - Retain trailing spaces in RDN values in DNs
Previously, this was only documented in the `Overview` section and missing from https://www.rubydoc.info/github/ruby-ldap/ruby-net-ldap/Net%2FLDAP:initialize
…-flexibility Add in ability for users to specify LDAP controls when conducting searches
Document `connect_timeout` in Constructor Details
Fix openssl error when using multiple hosts
Release 0.19.0
cschulze
approved these changes
Jul 8, 2024
straggler7
approved these changes
Jul 8, 2024
iliakg
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge in latest changes of ruby-net-ldap gem into our fork.