Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion projects/discussion-ui/src/lib/common/constants.json
Original file line number Diff line number Diff line change
Expand Up @@ -588,5 +588,24 @@
"TOPIC": "/discussion-forum/topic/",
"DISCUSSION": "/discussion-forum/",
"CATEGORY": "/discussion-forum/category/"
}
},
"MENUOPTIONS":[
{
"route": "All discussions",
"enable": true
},
{
"route": "categories",
"enable": true
},
{
"route": "tags",
"enable": true
},
{
"route": "my-discussion",
"enable": true
}

]
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { TelemetryUtilsService } from './../../telemetry-utils.service';
import * as CONSTANTS from './../../common/constants.json';
/* tslint:disable */
import * as _ from 'lodash'
import { ConfigService } from '../../services/config.service';
/* tslint:enable */

@Component({
Expand Down Expand Up @@ -36,6 +37,7 @@ export class DiscussCategoryComponent implements OnInit, OnDestroy {

constructor(
public discussService: DiscussionService,
public configService: ConfigService,
public router: Router,
public activatedRoute: ActivatedRoute,
private telemetryUtils: TelemetryUtilsService
Expand Down Expand Up @@ -90,14 +92,15 @@ export class DiscussCategoryComponent implements OnInit, OnDestroy {
this.isTopicCreator = _.get(response, 'privileges.topics:create') === true ? true : false;
this.showStartDiscussionModal = false;
if (_.get(response, 'children').length > 0) {
this.router.navigate([], { relativeTo: this.activatedRoute.parent, queryParams: { cid: this.categoryId } });
this.router.navigate([], { relativeTo: this.activatedRoute.parent, queryParams: { cid: this.categoryId }, queryParamsHandling: "merge" });
this.categories = [];
_.get(response, 'children').forEach(subCategoryData => {
this.categories.push(subCategoryData);
});
} else {
this.discussService.setContext(CONTEXT_PROPS.cid, this.categoryId);
this.router.navigate([`${CONSTANTS.ROUTES.CATEGORY}`, `${this.categoryId}`]);
let routerSlug = this.configService.getConfig().routerSlug ? this.configService.getConfig().routerSlug : ''
this.router.navigate([`${routerSlug}${CONSTANTS.ROUTES.CATEGORY}`, `${this.categoryId}`], {queryParamsHandling: "merge"});
}
}, error => {
this.showLoader = false;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import * as CONSTANTS from './../../common/constants.json';
/* tslint:disable */
import * as _ from 'lodash'
import { NSDiscussData } from '../../models/discuss.model';
import { ConfigService } from '../../services/config.service';
/* tslint:enable */

@Component({
Expand All @@ -27,7 +28,8 @@ export class DiscussHomeComponent implements OnInit {
public router: Router,
private route: ActivatedRoute,
private discussionService: DiscussionService,
private telemetryUtils: TelemetryUtilsService) {}
private configService: ConfigService,
private telemetryUtils: TelemetryUtilsService) { }

ngOnInit() {
this.telemetryUtils.logImpression(NSDiscussData.IPageName.HOME);
Expand All @@ -48,7 +50,8 @@ export class DiscussHomeComponent implements OnInit {
id: _.get(discussionData, 'tid'),
type: 'Topic'
});
this.router.navigate([`${CONSTANTS.ROUTES.TOPIC}${_.trim(_.get(discussionData, 'slug'))}`]);
let routerSlug = this.configService.getConfig().routerSlug ? this.configService.getConfig().routerSlug : ''
this.router.navigate([`${routerSlug}${CONSTANTS.ROUTES.TOPIC}${_.trim(_.get(discussionData, 'slug'))}`], {queryParamsHandling: "merge"});
}

getDiscussionList(slug: string) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ export class DiscussTagsComponent implements OnInit {
ngOnInit() {
this.telemetryUtils.setContext([]);
this.telemetryUtils.logImpression(NSDiscussData.IPageName.TAGS);
this.configService.setConfig()
// this.configService.setConfig(this.activatedRoute)
this.getParams = this.configService.getConfig()
this.cIds = JSON.parse(_.get(this.getParams, 'categories'))
this.cIds = _.get(this.getParams, 'categories')
console.log(this.getParams, this.cIds)

this.fetchAllTags();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import * as CONSTANTS from '../../common/constants.json';
/* tslint:disable */
import * as _ from 'lodash'
import { Subscription } from 'rxjs';
import { ConfigService } from '../../services/config.service';
/* tslint:enable */


Expand Down Expand Up @@ -41,6 +42,7 @@ export class DiscussionDetailsComponent implements OnInit, OnDestroy {
constructor(
private route: ActivatedRoute,
private discussionService: DiscussionService,
private configService: ConfigService,
private formBuilder: FormBuilder,
public router: Router,
private telemetryUtils: TelemetryUtilsService,
Expand Down Expand Up @@ -253,7 +255,8 @@ export class DiscussionDetailsComponent implements OnInit, OnDestroy {

navigateWithPage(page: any) {
if (page !== this.currentActivePage) {
this.router.navigate([`${CONSTANTS.ROUTES.CATEGORY} ${this.topicId}`], { queryParams: { page } });
let routerSlug = this.configService.getConfig().routerSlug ? this.configService.getConfig().routerSlug : ''
this.router.navigate([`${routerSlug}${CONSTANTS.ROUTES.CATEGORY} ${this.topicId}`], { queryParams: { page }, queryParamsHandling: "merge" });
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,45 @@ import { Location } from '@angular/common';

/* tslint:disable */
import * as _ from 'lodash'
import { IdiscussionConfig } from '../../models/discussion-config.model';
import { ConfigService } from '../../services/config.service';
import { OnDestroy } from '@angular/core';
/* tslint:enable */
@Component({
selector: 'lib-lib-entry',
templateUrl: './lib-entry.component.html',
styleUrls: ['./lib-entry.component.scss']
})
export class LibEntryComponent implements OnInit {
export class LibEntryComponent implements OnInit, OnDestroy {

data: IdiscussionConfig;
config: any;
pageKey: string;
constructor(
public activatedRoute: ActivatedRoute,
private discussionService: DiscussionService,
private configService: ConfigService,
private location: Location
) { }

ngOnInit() { }
ngOnInit() {

this.activatedRoute.queryParams.subscribe((params) => {
this.pageKey = _.get(params, 'page')
this.config = localStorage.getItem(_.get(params, 'page'))
this.configService.setConfig(JSON.parse(this.config))

this.data = this.configService.getConfig();
this.discussionService.userName = _.get(this.data, 'userName');
const rawCategories = _.get(this.data, 'categories');
this.discussionService.forumIds = _.get(rawCategories, 'result');
this.discussionService.initializeUserDetails(this.data.userName);
});
}

ngOnDestroy() {
localStorage.removeItem(this.pageKey)
}

goBack() {
this.location.back();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
</div>
<div class="flex flex-1" class="text-right mobile2">
<!-- Enable lated when other user can visit your profile -->
<!-- <span class="noocoments" mat-card-subtitle>Last online {{data.lastonline | pipeRelativeTime}}</span> -->
<!-- <span class="noocoments" mat-card-subtitle>Last online {{data?.lastonline | pipeRelativeTime}}</span> -->
</div>
</div>
</ng-container>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { Router } from '@angular/router';
import * as CONSTANTS from '../../common/constants.json';
/* tslint:disable */
import * as _ from 'lodash'
import { ConfigService } from '../../services/config.service';
/* tslint:enable */

@Component({
Expand All @@ -25,8 +26,9 @@ export class MyDiscussionComponent implements OnInit {
showLoader = false;
constructor(
private discussService: DiscussionService,
private configService: ConfigService,
public router: Router,
private telemetryUtils: TelemetryUtilsService) {}
private telemetryUtils: TelemetryUtilsService) { }

/** To fetch user details */
fetchUserProfile(userName) {
Expand All @@ -52,8 +54,8 @@ export class MyDiscussionComponent implements OnInit {
ngOnInit() {
this.telemetryUtils.setContext([]);
this.telemetryUtils.logImpression(NSDiscussData.IPageName.MY_DISCUSSION);
if (localStorage.getItem('userName')) {
this.fetchUserProfile(localStorage.getItem('userName'));
if (this.discussService.userName) {
this.fetchUserProfile(this.discussService.userName);
}
}

Expand Down Expand Up @@ -131,7 +133,8 @@ export class MyDiscussionComponent implements OnInit {

navigateToDiscussionDetails(discussionData) {
console.log('discussionData', discussionData);
this.router.navigate([`${CONSTANTS.ROUTES.TOPIC}${_.get(discussionData, 'topic.slug')}`]);
let routerSlug = this.configService.getConfig().routerSlug ? this.configService.getConfig().routerSlug : ''
this.router.navigate([`${routerSlug}${CONSTANTS.ROUTES.TOPIC}${_.get(discussionData, 'topic.slug')}`], {queryParamsHandling: "merge"});
}

logTelemetry(event) {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
<ul class="sb-sidebar-menu pl-0" *ngIf="!hideSidePanel">
<li class="df-sidebar-menu-list" *ngIf="false" (click)="navigate('home', $event)" id="all-discussions"><a>All discussions</a></li>
<li class="df-sidebar-menu-list" [ngClass]="{'menu-active': selectedTab === 'categories'}" (click)="navigate('categories', $event)" id="discussion-categories"><a>Categories</a></li>
<li class="df-sidebar-menu-list" [ngClass]="{'menu-active': selectedTab === 'tags'}" (click)="navigate('tags', $event)" id="discussion-tags"><a>Tags</a></li>
<li class="df-sidebar-menu-list" [ngClass]="{'menu-active': selectedTab === 'my-discussion'}" (click)="navigate('my-discussion', $event)" id="my-discussion"><a>My discussions</a></li>
<!-- <li class="df-sidebar-menu-list" *ngIf="false" (click)="navigate('home', $event)" id="all-discussions"><a>All discussions</a></li> -->
<li *ngFor='let d of menu' class="df-sidebar-menu-list" [ngClass]="{'menu-active': isActive(d.route)}"
(click)="navigate(d.route, $event)" id="d.route"><a>{{d.route}}</a></li>
</ul>

<!-- for mobile-view -->
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ import * as CONSTANTS from './../../common/constants.json';
/* tslint:disable */
import * as _ from 'lodash'
import { first } from 'rxjs/operators';
import { ConfigService } from '../../services/config.service';
import { IdiscussionConfig, IMenuOptions } from '../../models/discussion-config.model';
/* tslint:enable */

@Component({
Expand All @@ -24,9 +26,9 @@ export class SidePannelComponent implements OnInit, OnDestroy {

defaultPage = 'categories';

queryParams: any;
data: IdiscussionConfig;
hideSidePanel: boolean;

menu: Array<IMenuOptions> = [];
selectedTab: string;
showSideMenu: Boolean = true;

Expand All @@ -35,27 +37,34 @@ export class SidePannelComponent implements OnInit, OnDestroy {
public discussService: DiscussionService,
public activatedRoute: ActivatedRoute,
private telemetryUtils: TelemetryUtilsService,
private configService: ConfigService
) { }

ngOnInit() {
// TODO: loader or spinner
this.hideSidePanel = document.body.classList.contains('widget');
this.telemetryUtils.logImpression(NSDiscussData.IPageName.HOME);
this.paramsSubscription = this.activatedRoute.queryParams.pipe(first()).subscribe((params) => {
console.log('params', params);
this.queryParams = params;
this.discussService.userName = _.get(params, 'userName');
const rawCategories = JSON.parse(_.get(params, 'categories'));
this.discussService.forumIds = _.get(rawCategories , 'result');
});
localStorage.setItem('userName', _.get(this.queryParams, 'userName'));
this.discussService.initializeUserDetails(localStorage.getItem('userName'));
if (this.discussService.forumIds) {
this.navigate(this.defaultPage);
} else {
// TODO: Error toast
console.log('forum ids not found');
this.data = this.configService.getConfig()
let menuArr = this.data.menuOptions && this.data.menuOptions.length > 0 ? this.data.menuOptions : CONSTANTS.MENUOPTIONS
// })
for (let i = 0; i < menuArr.length; i++) {
if (menuArr[i].enable) {
this.menu.push(menuArr[i])
}
}

}

isActive(selectedItem) {
if (this.router.url.indexOf(`/${selectedItem}`) > -1 || this.selectedTab === selectedItem) {
if (!this.selectedTab) {
this.selectedTab = selectedItem
}
return true
} else if (selectedItem === 'categories' && !this.selectedTab) {
return true
}
return false
}

navigate(pageName: string, event?) {
Expand All @@ -64,7 +73,7 @@ export class SidePannelComponent implements OnInit, OnDestroy {
if (event) {
this.telemetryUtils.logInteract(event, NSDiscussData.IPageName.HOME);
}
this.router.navigate([`${CONSTANTS.ROUTES.DISCUSSION}${pageName}`], { queryParams: this.queryParams });
this.router.navigate([`${pageName}`], { relativeTo: this.activatedRoute, queryParamsHandling: "merge" });
}

ngOnDestroy() {
Expand All @@ -75,10 +84,10 @@ export class SidePannelComponent implements OnInit, OnDestroy {

showMenuButton() {
this.showSideMenu = this.showSideMenu ? false : true;
}
}

closeNav() {
this.showSideMenu = this.showSideMenu ? false : true;
}

closeNav(){
this.showSideMenu = this.showSideMenu ? false : true;
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ const routes: Routes = [
path: '',
component: LibEntryComponent,
children: [
{
path: '',
pathMatch: 'full',
component: DiscussCategoryComponent
},
{
path: 'home',
pathMatch: 'full',
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { Component, Input, OnInit } from '@angular/core';
import { Router } from '@angular/router'
import { ConfigService } from '../../services/config.service';
import * as CONSTANTS from './../../common/constants.json';

@Component({
Expand All @@ -12,13 +13,16 @@ export class RelatedDiscussionComponent implements OnInit {
@Input()
relatedDiscussions!: []

constructor(private router: Router) { }
constructor(private router: Router,
private configService: ConfigService
) { }

ngOnInit() {
}

getDiscussion(discuss) {
this.router.navigate([`${CONSTANTS.ROUTES.DISCUSSION}topic/${discuss.slug}`]);
let routerSlug = this.configService.getConfig().routerSlug ? this.configService.getConfig().routerSlug : ''
this.router.navigate([`${routerSlug}${CONSTANTS.ROUTES.DISCUSSION}topic/${discuss.slug}`], {queryParamsHandling: "merge"});
}

}
22 changes: 22 additions & 0 deletions projects/discussion-ui/src/lib/models/discussion-config.model.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
export interface IdiscussionConfig {
menuOptions?: Array<IMenuOptions>
userName: string
context: Object
categories: Icategory
path: string
routerSlug: string
}

export interface Icontext {
id: number
}

export interface IMenuOptions {
route: string
enable: boolean
}

export interface Icategory {
result : Array<string>
}

Loading