Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS: convert u32 to u16 for macos #7

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

viduranga
Copy link
Contributor

@viduranga viduranga commented Feb 28, 2024

MacOS only supports U16 unicodes instead of U32. So for MacOS unicode macros, made a fix to convert U32s that exceed U16 length to two U16 codes

@viduranga viduranga marked this pull request as draft February 29, 2024 06:57
@sunaku sunaku added this to the v36 milestone Mar 7, 2024
@viduranga viduranga force-pushed the macos_u16_emoji_fix branch from 1905bfe to 3fcb195 Compare March 12, 2024 20:14
@viduranga viduranga force-pushed the macos_u16_emoji_fix branch from 3fcb195 to 8fbcbfe Compare March 12, 2024 20:18
@viduranga viduranga marked this pull request as ready for review March 12, 2024 20:18
@sunaku sunaku merged commit 4193630 into sunaku:main Mar 14, 2024
@sunaku
Copy link
Owner

sunaku commented Mar 14, 2024

Merged now, thank you! 🙏

@mbqr
Copy link

mbqr commented Mar 14, 2024 via email

@Mathijs-Bakker
Copy link

how do i stop emails smh

On Mar 13, 2024, at 11:25 PM, Suraj N. Kurapati @.***> wrote: Merged now, thank you! 🙏 — Reply to this email directly, view it on GitHub <#7 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVPTQDMYA2VWINEGNVT7ZKTYYEKCZAVCNFSM6AAAAABD64F53OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJWGMZDAMZWGU. You are receiving this because you are subscribed to this thread.

Click/change Unwatch in back to main page

@mbqr
Copy link

mbqr commented Mar 14, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants