-
Notifications
You must be signed in to change notification settings - Fork 59
[EUV2][HoaiTTT] UT do homework ex3 to ex7 #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[EUV2][HoaiTTT] UT do homework ex3 to ex7 #38
Conversation
| $controller = new Exercise05Controller($this->orderService); | ||
|
|
||
| $this->assertInstanceOf(Exercise05Controller::class, $controller); | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove blank line e ơi
| $this->assertEquals(compact('optionCoupons', 'optionReceives'), $view->getData()); | ||
| } | ||
|
|
||
| public function test_store() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cái tên hàm nên nói cụ thể e test case gì và ntn nhé
| ]; | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blank line nhiều thế e
| ], $view->getData()); | ||
| } | ||
|
|
||
| public function test_calculate() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
như trên :D
|
|
||
| public function test_calculate() | ||
| { | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
để ý mấy cái blank line thừa nhé
Purpose/Notes
Do homework Exercise03 to Exercise07
Screenshot
Checklist (*)