Skip to content

Conversation

@luatvd-1542
Copy link

@luatvd-1542 luatvd-1542 commented May 22, 2021

Purpose/Notes

Screenshot

image

Checklist (*)

  • Pull request has been self-reviewed
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All CI builds passed successfully (all builds are green)

public function testIndex()
{
$response = $this->get(action([Exercise05Controller::class, 'index']));
$response->assertViewIs('exercise05::index');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nên check thêm các variable được truyền vào view nữa thì tốt hơn e ạ

parent::setUp(); // TODO: Change the autogenerated stub
}

public function testIndex()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://sun-unit-test-training.github.io/php-testing-guideline/06-checklist/#1-self-describing-test-method

Tên function nên thể hiện được phục vụ test case nào và expect của test case của test case đó

VÍ dụ ở đây:
test_index_return_view_success

*
* @dataProvider providerDataStore
*/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove blank line e ơi :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants