-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ExternalLink icon #2135
Add ExternalLink icon #2135
Conversation
Hey @a5e, Thanks! |
🦋 Changeset detectedLatest commit: bf1ebdd The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## main #2135 +/- ##
=======================================
Coverage 92.09% 92.09%
=======================================
Files 171 171
Lines 3607 3607
Branches 1270 1270
=======================================
Hits 3322 3322
Misses 264 264
Partials 21 21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The icon color should not be hard-coded. From the (docs):
Unless icons are a brand logo (e.g. the Mastercard logo), all SVG fills should always be
currentColor
. This lets developers style icons using CSS instead of overriding fill colors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! 🙌
Addresses #ticket-number.
Purpose
Added new icon
ExternalLink
in size 16 and 24.Approach and changes
Definition of done