Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExternalLink icon #2135

Merged
merged 2 commits into from
May 31, 2023
Merged

Add ExternalLink icon #2135

merged 2 commits into from
May 31, 2023

Conversation

a5e
Copy link
Contributor

@a5e a5e commented May 29, 2023

Addresses #ticket-number.

Purpose

Added new icon ExternalLink in size 16 and 24.

Approach and changes

  • Exported and optimized the svgs from Figma.
  • Updated the manifest.
  • Created a changeset.

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@a5e a5e added the 🗂 icons label May 29, 2023
@a5e a5e requested a review from a team as a code owner May 29, 2023 14:08
@a5e a5e requested review from pdrmdrs and removed request for a team May 29, 2023 14:08
@sumup-clark
Copy link

sumup-clark bot commented May 29, 2023

Hey @a5e,
we are super excited that you are contributing! 🎉There's one more thing you need to do. Please accept our Contributor License Agreement. It helps you and us to collaborate on clear terms and focus on what we love most: code.

Thanks!

@changeset-bot
Copy link

changeset-bot bot commented May 29, 2023

🦋 Changeset detected

Latest commit: bf1ebdd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sumup/icons Minor
@sumup/circuit-ui Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2023 5:51am

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #2135 (bf1ebdd) into main (710ccfb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2135   +/-   ##
=======================================
  Coverage   92.09%   92.09%           
=======================================
  Files         171      171           
  Lines        3607     3607           
  Branches     1270     1270           
=======================================
  Hits         3322     3322           
  Misses        264      264           
  Partials       21       21           

Copy link
Member

@connor-baer connor-baer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon color should not be hard-coded. From the (docs):

Unless icons are a brand logo (e.g. the Mastercard logo), all SVG fills should always be currentColor. This lets developers style icons using CSS instead of overriding fill colors.

packages/icons/web/v2/external_link_16.svg Outdated Show resolved Hide resolved
packages/icons/web/v2/external_link_24.svg Outdated Show resolved Hide resolved
Copy link
Member

@connor-baer connor-baer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! 🙌

@connor-baer connor-baer removed the request for review from pdrmdrs May 30, 2023 05:49
@connor-baer connor-baer merged commit 8a771fa into main May 31, 2023
@connor-baer connor-baer deleted the add-external-link-icon branch May 31, 2023 15:03
@connor-baer connor-baer mentioned this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants