Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the AddItems icon #2099

Merged
merged 2 commits into from
May 12, 2023
Merged

Deprecate the AddItems icon #2099

merged 2 commits into from
May 12, 2023

Conversation

connor-baer
Copy link
Member

Closes #1717.

Approach and changes

  • Generate a JSDoc comment for deprecated icons
  • Add a deprecation note for the AddItems icon
  • Bonus: Replace dedent with prettier
  • Bonus: Remove dependency on lodash

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer requested a review from robinmetral May 11, 2023 14:41
@connor-baer connor-baer requested a review from a team as a code owner May 11, 2023 14:41
@changeset-bot
Copy link

changeset-bot bot commented May 11, 2023

🦋 Changeset detected

Latest commit: f1fde10

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sumup/icons Minor
@sumup/circuit-ui Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2023 8:09am

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #2099 (f1fde10) into main (6a79f22) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2099   +/-   ##
=======================================
  Coverage   92.09%   92.09%           
=======================================
  Files         168      168           
  Lines        3553     3553           
  Branches     1241     1241           
=======================================
  Hits         3272     3272           
  Misses        260      260           
  Partials       21       21           

Copy link
Contributor

@robinmetral robinmetral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Should we document the deprecation process for icons somewhere?

packages/icons/scripts/web.ts Show resolved Hide resolved
Copy link
Contributor

@robinmetral robinmetral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

packages/icons/CONTRIBUTING.md Show resolved Hide resolved
@connor-baer connor-baer merged commit 9d740bd into main May 12, 2023
@connor-baer connor-baer deleted the deprecation/icons-add-items branch May 12, 2023 08:50
@connor-baer connor-baer mentioned this pull request May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate the AddItems icon
2 participants