Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependencies #2082

Closed
wants to merge 2 commits into from
Closed

Remove unused dependencies #2082

wants to merge 2 commits into from

Conversation

connor-baer
Copy link
Member

Purpose

I noticed a couple of unused dependencies in Circuit UI's package.json file and decided to clean them up.

Approach and changes

  • Remove @emotion/cache as a peer dependency
  • Remove @emotion/cache, component-playground, cross-env, react-docgen, and react-docgen-annotation-resolver as dev dependencies

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer added the 📦 dependencies Pull requests that update a dependency file label May 6, 2023
@connor-baer connor-baer requested a review from a team as a code owner May 6, 2023 14:27
@vercel
Copy link

vercel bot commented May 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2023 2:28pm

@connor-baer connor-baer requested review from pdrmdrs and removed request for a team May 6, 2023 14:27
@changeset-bot
Copy link

changeset-bot bot commented May 6, 2023

🦋 Changeset detected

Latest commit: 0f0952d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented May 6, 2023

Codecov Report

Merging #2082 (0f0952d) into next (ba33611) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #2082   +/-   ##
=======================================
  Coverage   96.91%   96.91%           
=======================================
  Files         258      258           
  Lines       23163    23163           
  Branches     2165     2165           
=======================================
  Hits        22449    22449           
  Misses        707      707           
  Partials        7        7           

@connor-baer connor-baer added the 🚢 ready to merge Automatically merge the PR once all requirements are met label May 6, 2023
@connor-baer
Copy link
Member Author

Superseded by #2091.

@connor-baer connor-baer closed this May 8, 2023
@connor-baer connor-baer deleted the chore/clean-deps branch August 5, 2023 09:05
@connor-baer connor-baer restored the chore/clean-deps branch August 5, 2023 09:05
@connor-baer connor-baer deleted the chore/clean-deps branch August 5, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗂 circuit-ui 📦 dependencies Pull requests that update a dependency file 🚢 ready to merge Automatically merge the PR once all requirements are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant