529-formbuilder-encoding-issue

[ilaria-orlando]

Summary by Sourcery

Bug Fixes:

• Decode HTML entities for dropdown option labels in buildForm and for submitted values in validateForm to correctly handle accented characters

[sourcery-ai]

Reviewer's Guide

This PR updates the FormBuilder widget to decode HTML entities for dropdown options and submitted values, ensuring accented characters render and validate correctly.

Class diagram for updated FormBuilder dropdown handling

classDiagram
    class Form {
        - buildForm(): void
        - validateForm(): void
    }
    %% Highlight changes in buildForm and validateForm
    Form : +html_entity_decode for dropdown values in buildForm
    Form : +html_entity_decode for submitted dropdown value in validateForm

Loading

File-Level Changes

Change	Details	Files
Decode HTML entities for dropdown option labels	Replace direct reuse of values with array_map(html_entity_decode) to decode each label Combine original values with decoded labels using array_combine	src/Frontend/Modules/FormBuilder/Widgets/Form.php
Decode HTML entities for submitted dropdown value in validation	Add html_entity_decode on fieldData['value'] when field type is 'dropdown'	src/Frontend/Modules/FormBuilder/Widgets/Form.php

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ilaria-orlando - I've reviewed your changes - here's some feedback:

• Always pass the correct charset (e.g. 'UTF-8') to html_entity_decode so French accents are handled properly in multi-byte contexts.
• The dropdown value/label decoding logic is duplicated between buildForm and validateForm—consider extracting it into a shared helper to keep transformations consistent.
• Right now keys remain encoded while labels are decoded, which can make the strict array_search brittle; normalize both sides the same way so lookups always match.

Prompt for AI Agents

Please address the comments from this code review:
## Overall Comments
- Always pass the correct charset (e.g. 'UTF-8') to html_entity_decode so French accents are handled properly in multi-byte contexts.
- The dropdown value/label decoding logic is duplicated between buildForm and validateForm—consider extracting it into a shared helper to keep transformations consistent.
- Right now keys remain encoded while labels are decoded, which can make the strict array_search brittle; normalize both sides the same way so lookups always match.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[Copilot]

Pull Request Overview

This PR fixes an encoding issue with HTML entities in FormBuilder widgets, specifically addressing problems with accented characters in dropdown options and form submissions.

Key changes:

• Decode HTML entities for dropdown option labels during form building
• Decode HTML entities for submitted values during form validation for dropdown, checkbox, and radiobutton fields
• Map encoded values to their decoded counterparts for proper display and validation