Skip to content

Conversation

@tijsverkoyen
Copy link
Member

@tijsverkoyen tijsverkoyen commented Oct 27, 2025

See sumocoders/FrameworkCoreBundle#213

Merge sumocoders/FrameworkCoreBundle#213 first.

Summary by Sourcery

Integrate a new Stimulus confirmation controller by registering it in the bootstrap initialization and adding it to the asset import list for new projects.

New Features:

  • Add a Stimulus 'confirm' controller to display a confirmation modal before executing link clicks or form submissions
  • Include the 'Confirm' controller in the project asset imports during setup

@tijsverkoyen tijsverkoyen requested a review from Copilot October 27, 2025 12:28
@sourcery-ai
Copy link

sourcery-ai bot commented Oct 27, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds a new Stimulus Confirm controller by importing and registering it in the client bootstrap, and includes it in the project skeleton’s asset setup.

Class diagram for Stimulus controller registration

classDiagram
    class Confirm
    class PasswordStrengthChecker
    class TogglePassword
    class FormCollection
    class ScrollToTop
    class App
    App : register(controllerName, controllerClass)
    App --> Confirm : registers
    App --> PasswordStrengthChecker : registers
    App --> TogglePassword : registers
    App --> FormCollection : registers
    App --> ScrollToTop : registers
Loading

File-Level Changes

Change Details Files
Register Confirm Stimulus controller in the bootstrap initialization
  • Import Confirm from 'sumocoders/Confirm'
  • Invoke app.register('confirm', Confirm)
scripts/assets/js/bootstrap.js
Add Confirm controller to the project skeleton’s asset mapping
  • Append 'Confirm' => 'controllers/confirm_controller.js' to the packages array
src/Skeleton/PostCreateProject.php

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new Stimulus controller for displaying confirmation modals before link or form submissions. The implementation integrates a Confirm controller from the sumocoders/FrameworkCoreBundle package into the project's asset pipeline.

  • Adds the Confirm controller to the importAssets package list
  • Registers the Confirm Stimulus controller in the bootstrap

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Skeleton/PostCreateProject.php Adds 'Confirm' controller to the assets import list
scripts/assets/js/bootstrap.js Imports and registers the Confirm Stimulus controller

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@tijsverkoyen tijsverkoyen merged commit d66f481 into master Oct 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants