-
Couldn't load subscription status.
- Fork 5
feat: Stimulus controller to show a confirm modal before link or form… #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a new Stimulus Confirm controller by importing and registering it in the client bootstrap, and includes it in the project skeleton’s asset setup. Class diagram for Stimulus controller registrationclassDiagram
class Confirm
class PasswordStrengthChecker
class TogglePassword
class FormCollection
class ScrollToTop
class App
App : register(controllerName, controllerClass)
App --> Confirm : registers
App --> PasswordStrengthChecker : registers
App --> TogglePassword : registers
App --> FormCollection : registers
App --> ScrollToTop : registers
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new Stimulus controller for displaying confirmation modals before link or form submissions. The implementation integrates a Confirm controller from the sumocoders/FrameworkCoreBundle package into the project's asset pipeline.
- Adds the
Confirmcontroller to the importAssets package list - Registers the
ConfirmStimulus controller in the bootstrap
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Skeleton/PostCreateProject.php | Adds 'Confirm' controller to the assets import list |
| scripts/assets/js/bootstrap.js | Imports and registers the Confirm Stimulus controller |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See sumocoders/FrameworkCoreBundle#213
Merge sumocoders/FrameworkCoreBundle#213 first.
Summary by Sourcery
Integrate a new Stimulus confirmation controller by registering it in the bootstrap initialization and adding it to the asset import list for new projects.
New Features: