Refactor jsdata and theme #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tijsverkoyen
reviewed
Oct 1, 2021
tijsverkoyen
reviewed
Oct 1, 2021
sanderdlm
force-pushed
the
refactor-jsdata-and-theme
branch
from
26da26a to
5a003a3
Compare
tijsverkoyen
approved these changes
Oct 4, 2021
added 10 commits
November 17, 2021 09:44
sanderdlm
force-pushed
the
refactor-jsdata-and-theme
branch
from
241a6fe to
6ad3732
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having our jsData as an inline script is not ideal. It's a possible vulnerability and we have to trust that it will be present in our style package.
Symfony also recommends different ways to pass data from Twig to JS: https://symfony.com/doc/current/frontend/encore/server-data.html. The locale we used to pass in the jsData is already present as the lang attribute, which we can read in JS with
This only leaves the current theme and the path to the dark style CSS file. With this PR I propose we set both as data attributes on our body tag, as suggested by the Symfony docs. We can verify if they're properly set and then read their values in our style package.
PR in style package: sumocoders/FrameworkStylePackage#65