-
Couldn't load subscription status.
- Fork 6
373 Invokable commands #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR upgrades Symfony dependencies to version 7.3 and refactors the TranslateCommand to an invokable command using constructor property promotion and the __invoke() method. Class diagram for refactored TranslateCommandclassDiagram
class TranslateCommand {
+__construct(ParameterBagInterface parameters)
+__invoke(OutputInterface output): int
-parameters: ParameterBagInterface (removed)
+parameters: ParameterBagInterface (readonly, promoted)
}
TranslateCommand --|> Command
ParameterBagInterface <.. TranslateCommand
Class diagram for Symfony dependency upgradesclassDiagram
class SymfonyForm {
<<interface>>
version: 7.3
}
class SymfonyAsset {
<<interface>>
version: 7.3
}
class SymfonyConsole {
<<interface>>
version: 7.3
}
class SymfonySecurityBundle {
<<interface>>
version: 7.3
}
class SymfonyTranslation {
<<interface>>
version: 7.3
}
class SymfonyTwigBundle {
<<interface>>
version: 7.3
}
class SymfonyDoctrineMessenger {
<<interface>>
version: 7.3
}
class SymfonyPhpunitBridge {
<<interface>>
version: 7.3
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @absumo - I've reviewed your changes - here's some feedback:
- Double-check that removing the InputInterface parameter from __invoke matches Symfony 7.3’s invokable command signature to avoid runtime mismatches.
- Ensure the Symfony 7.3 minor version bump is compatible with all other dependencies to prevent unexpected issues.
- Consider consolidating individual Symfony package version constraints into a single requirement to simplify future upgrades.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Double-check that removing the InputInterface parameter from __invoke matches Symfony 7.3’s invokable command signature to avoid runtime mismatches.
- Ensure the Symfony 7.3 minor version bump is compatible with all other dependencies to prevent unexpected issues.
- Consider consolidating individual Symfony package version constraints into a single requirement to simplify future upgrades.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Bump Symfony dependency versions and refactor the TranslateCommand to use PHP 8 features and an invokable signature.
Enhancements: