Skip to content

Conversation

@absumo
Copy link
Contributor

@absumo absumo commented Jul 30, 2025

Summary by Sourcery

Remove the deprecated secrets:get console command and its service registration in favor of using the secrets:reveal command

Enhancements:

  • Drop the old secrets:get command from the codebase to streamline secret handling

Chores:

  • Unregister and delete the SecretsGetCommand and its service definition

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @absumo - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated secrets:get console command and replaces it with the existing secrets:reveal command for secret handling operations.

  • Remove the custom SecretsGetCommand class that was duplicating functionality
  • Unregister the command from the service container configuration

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Command/SecretsGetCommand.php Complete removal of the deprecated SecretsGetCommand class
config/services.php Removal of service registration for the deleted SecretsGetCommand

@absumo absumo merged commit 023a493 into master Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants