319 stimulus #171
Merged
319 stimulus #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 26 commits
October 15, 2024 10:14
For now we will disable Turbo, because it will mess with some of the JS functionally. We will use it for it's Turbo frames in the Toast functionally
Use symfony/autocomplete-ux instead (default installed)
Not needed anymore because of scroll-behaviour: smooth in bootstrap css
jonasdekeukelaere
requested review from
absumo,
daphneslootmans and
tijsverkoyen
This was referenced Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert our JS to stimulus controllersWorks together with changes to our sumocoders/application-skeleton#136