Skip to content

Conversation

@daphneslootmans
Copy link
Contributor

@daphneslootmans daphneslootmans commented Oct 10, 2025

Summary by Sourcery

Redesign user administration templates to improve responsive layout using Bootstrap grid classes instead of fixed widths

Enhancements:

  • Convert the user overview from a table to a responsive card grid with col-md-6 and col-lg-4 columns
  • Replace fixed col-6 classes in user add/edit form layouts with col-md-6 for better responsiveness

@sourcery-ai
Copy link

sourcery-ai bot commented Oct 10, 2025

Reviewer's Guide

Refactor user overview from a table-based list to a responsive Bootstrap card grid and update form layouts to use responsive column classes.

Class diagram for updated user admin overview template structure

classDiagram
  class User {
    +username: string
    +getDisplayRoles: array
    +confirmed: bool
    +enabled: bool
  }
  class "UserOverviewTable" {
    -table layout
    -table rows for users
    -table columns: Username, Roles, Confirmed, Enabled, Edit, Impersonate
  }
  class "UserOverviewCardGrid" {
    -responsive card grid layout
    -card for each user
    -card sections: Username, Roles, Confirmed, Enabled, Edit, Impersonate
  }
  UserOverviewTable <|-- UserOverviewCardGrid
Loading

File-Level Changes

Change Details Files
Convert user list to responsive Bootstrap card grid
  • Replace structure with
    container
  • Wrap each user in a .col-md-6 .col-lg-4 card
  • Move username, roles, and status icons into card-body with structured rows
  • Relocate action links into card-footer and apply button styling
  • Include conditional impersonation button within the card layout
  • templates/user/admin/overview.html.twig
    Switch fixed .col-6 class to responsive .col-md-6 in form templates
    • Update div class in add.html.twig from col-6 to col-md-6
    • Update div class in edit.html.twig from col-6 to col-md-6
    templates/user/admin/add.html.twig
    templates/user/admin/edit.html.twig

    Tips and commands

    Interacting with Sourcery

    • Trigger a new review: Comment @sourcery-ai review on the pull request.
    • Continue discussions: Reply directly to Sourcery's review comments.
    • Generate a GitHub issue from a review comment: Ask Sourcery to create an
      issue from a review comment by replying to it. You can also reply to a
      review comment with @sourcery-ai issue to create an issue from it.
    • Generate a pull request title: Write @sourcery-ai anywhere in the pull
      request title to generate a title at any time. You can also comment
      @sourcery-ai title on the pull request to (re-)generate the title at any time.
    • Generate a pull request summary: Write @sourcery-ai summary anywhere in
      the pull request body to generate a PR summary at any time exactly where you
      want it. You can also comment @sourcery-ai summary on the pull request to
      (re-)generate the summary at any time.
    • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
      request to (re-)generate the reviewer's guide at any time.
    • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
      pull request to resolve all Sourcery comments. Useful if you've already
      addressed all the comments and don't want to see them anymore.
    • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
      request to dismiss all existing Sourcery reviews. Especially useful if you
      want to start fresh with a new review - don't forget to comment
      @sourcery-ai review to trigger a new review!

    Customizing Your Experience

    Access your dashboard to:

    • Enable or disable review features such as the Sourcery-generated pull request
      summary, the reviewer's guide, and others.
    • Change the review language.
    • Add, remove or edit custom review instructions.
    • Adjust other review settings.

    Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • The impersonation link is still wrapped in a tag inside the card-footer—replace that with a div or span to keep the HTML structure valid.
  • Replacing the table with cards removes semantic tabular markup and accessible column headers; consider adding ARIA roles or keeping a table for better accessibility.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The impersonation link is still wrapped in a <td> tag inside the card-footer—replace that with a div or span to keep the HTML structure valid.
- Replacing the table with cards removes semantic tabular markup and accessible column headers; consider adding ARIA roles or keeping a table for better accessibility.

## Individual Comments

### Comment 1
<location> `templates/user/admin/overview.html.twig:44-49` </location>
<code_context>
     {% for user in users %}
-      <tr>
-        <th scope="row">{{ user.username }}</th>
-        <td>
-        {% for role in user.getDisplayRoles %}
-          {% if loop.index0 > 0 %},{% endif %}
-          {{ role|trans }}
-        {% endfor %}
-        </td>
-        <td>
-          {% if user.confirmed %}
</code_context>

<issue_to_address>
**issue:** Table cell <td> elements are used outside of a table context.

Replace <td> elements in card-footer with <div> or another suitable tag to ensure semantic HTML and prevent rendering issues.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@daphneslootmans daphneslootmans merged commit 13ce2cd into main Oct 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants