-
Couldn't load subscription status.
- Fork 1
fix(users) Make search in user overview work #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Switching to GET also makes sure we can link to a filtered overview
Reviewer's guide (collapsed on small PRs)Reviewer's GuideConvert the user overview’s filter form to submit via GET and disable CSRF protection so filter state can be linked/bookmarked. Sequence diagram for user overview filter form submission via GETsequenceDiagram
actor User
participant Browser
participant Server
User->>Browser: Enter filter term in form
User->>Browser: Submit filter form (GET)
Browser->>Server: GET /users?term=...
Server-->>Browser: Return filtered user list
Browser-->>User: Display filtered results
Class diagram for updated FilterType form configurationclassDiagram
class FilterType {
+buildForm(FormBuilderInterface $builder, array $options)
+configureOptions(OptionsResolver $resolver)
-method: GET (added)
-csrf_protection: false (added)
-data_class: FilterDataTransferObject
}
class FilterDataTransferObject
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the search functionality in the user overview by switching the form method from POST to GET and disabling CSRF protection to enable linkable filtered results.
- Changed form method to GET to allow URL-based filtering
- Disabled CSRF protection for the filter form
- Refactored the options resolver configuration for better readability
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switching to GET also makes sure we can link to a filtered overview
Summary by Sourcery
Enable deep-linking to filtered user overview by updating the filter form to use GET requests and disabling CSRF protection
Bug Fixes:
Enhancements: