- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1
373 Invokable commands #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | Reviewer's GuideThis PR refactors the CreateCommand class to leverage Symfony Console’s invokable command pattern with attribute-based argument mapping, makes the message bus dependency readonly, and bumps all Symfony package versions from ^7.2 to ^7.3. Sequence diagram for CreateCommand invokable executionsequenceDiagram
    actor User
    participant Console as Symfony Console
    participant CreateCommand
    participant Validator as ValidatorInterface
    participant Bus as MessageBusInterface
    User->>Console: Run create:user command with email and roles
    Console->>CreateCommand: __invoke(io, email, roles)
    CreateCommand->>Validator: validate(CreateUser)
    Validator-->>CreateCommand: ConstraintViolationList
    alt No validation errors
        CreateCommand->>Bus: dispatch(CreateUser)
        Bus-->>CreateCommand: (dispatch result)
        CreateCommand-->>Console: return SUCCESS
    else Validation errors
        CreateCommand-->>Console: display errors
        CreateCommand-->>Console: return FAILURE
    end
Class diagram for refactored CreateCommandclassDiagram
    class CreateCommand {
        <<Symfony\Component\Console\Command\Command>>
        +__construct(MessageBusInterface messageBus, ValidatorInterface validator)
        +__invoke(SymfonyStyle io, string email, array roles = ['ROLE_USER']) : int
        -messageBus : MessageBusInterface (readonly)
        -validator : ValidatorInterface (readonly)
    }
    class CreateUser {
        +email : string
        +roles : array
    }
    CreateCommand ..> CreateUser : uses
    CreateCommand ..> MessageBusInterface
    CreateCommand ..> ValidatorInterface
    CreateCommand ..> SymfonyStyle
File-Level Changes
 Tips and commandsInteracting with Sourcery
 Customizing Your ExperienceAccess your dashboard to: 
 Getting Help
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
              
                    tijsverkoyen
  
              
              approved these changes
              
                  
                    Aug 8, 2025 
                  
              
              
            
            
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Summary by Sourcery
Refactor the CreateCommand class to use Symfony’s invokable command signature with attribute-based arguments and update Symfony dependencies to version 7.3.
Enhancements:
Build: