317 Locale detection

[absumo]

Summary by Sourcery

New Features:

• Detect user's preferred locale on the home route and include it in the redirect

[sourcery-ai]

Reviewer's Guide

Enhance HomeController to detect and apply the user's preferred locale for the redirect to user_profile by injecting the Request service and supported locales parameter.

Sequence diagram for locale detection and redirect in HomeController

sequenceDiagram
    actor User
    participant HomeController
    participant Request
    participant user_profile
    User->>HomeController: GET /
    HomeController->>Request: getPreferredLanguage(locales)
    Request-->>HomeController: preferred_locale
    HomeController->>user_profile: Redirect with _locale=preferred_locale
    user_profile-->>User: Response

Loading

File-Level Changes

Change	Details	Files
Implement locale detection in HomeController	Add Request parameter to __invoke Autowire supported locales array Pass preferred locale to redirectToRoute	src/Controller/HomeController.php

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @absumo - I've reviewed your changes and they look great!

Prompt for AI Agents

Please address the comments from this code review:
## Individual Comments

### Comment 1
<location> `src/Controller/HomeController.php:17` </location>
<code_context>
+        Request $request,
+        #[Autowire('%locales%')] array $locales,
+    ): Response {
+        return $this->redirectToRoute('user_profile', ['_locale' => $request->getPreferredLanguage($locales)]);
     }
 }
</code_context>

<issue_to_address>
Consider handling the case where getPreferredLanguage returns null.

If getPreferredLanguage returns null, '_locale' may be set to an invalid value. Consider adding a fallback locale to ensure consistent behavior.
</issue_to_address>

<suggested_fix>
<<<<<<< SEARCH
        return $this->redirectToRoute('user_profile', ['_locale' => $request->getPreferredLanguage($locales)]);
=======
        $preferredLocale = $request->getPreferredLanguage($locales);
        if ($preferredLocale === null && !empty($locales)) {
            $preferredLocale = $locales[0];
        }
        return $this->redirectToRoute('user_profile', ['_locale' => $preferredLocale]);
>>>>>>> REPLACE

</suggested_fix>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}