340 multi language

[absumo]

Summary by Sourcery

Enhancements:

• Update the admin security path pattern to use a regex that includes optional locale segments

[sourcery-ai]

Reviewer's Guide

The pull request updates the security configuration to allow the /admin route to be optionally prefixed by a locale segment, enabling multi-language support in access rules.

Flow diagram for admin route access with optional locale prefix

flowchart TD
  A[User requests /admin or /<locale>/admin]
  B{Does user have ROLE_ADMIN?}
  C[Access granted]
  D[Access denied]

  A --> B
  B -- Yes --> C
  B -- No --> D

Loading

File-Level Changes

Change	Details	Files
Admin route pattern extended for optional locale prefix	Replaced the static /admin path definition Wrapped the locale regex in an optional group (/(%locales_regex%))? before /admin Ensured existing routes without a locale prefix continue to match	config/packages/security.yaml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @absumo - I've reviewed your changes and they look great!

Prompt for AI Agents

Please address the comments from this code review:
## Individual Comments

### Comment 1
<location> `config/packages/security.yaml:48` </location>
<code_context>
         - { route: 'user_reset_password', roles: PUBLIC_ACCESS }
         - { route: 'user_profile', roles: ROLE_USER }
-        - { path: ^/admin, roles: ROLE_ADMIN }
+        - { path: '^(/(%locales_regex%))?/admin', roles: ROLE_ADMIN }

 when@test:
</code_context>

<issue_to_address>
Consider potential edge cases with the new admin path regex.

Verify that the optional locale prefix in the regex does not cause unintended route matches or ambiguity, and confirm that %locales_regex% cannot be empty to avoid unexpected behavior.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}