- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1
362 improve code #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
362 improve code #44
Conversation
Use a separate url so this can be measured in analytic tools. This makes it work with Turbo also.
209c39e    to
    6fa0f91      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR aims to improve and modernize various aspects of the codebase by removing legacy configurations, updating dependency injection and routing conventions, and reworking front-end asset management. Key changes include the removal of the legacy webpack.config.js, extensive renaming of routes and message properties for consistency, and updates to configuration files and asset imports.
Reviewed Changes
Copilot reviewed 95 out of 106 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description | 
|---|---|
| webpack.config.js | Removed legacy webpack configuration in favor of Symfony’s built-in asset management. | 
| translations/messages+intl-icu.nl.yaml | Updated/added translation strings (note potential spelling issue in one phrase). | 
| Multiple Controller, Handler, Message, and Form files | Converted method-based user accessors to public readonly property usage and updated DI. | 
| package.json | Removed the file, indicating a shift away from npm-managed assets to alternate approaches. | 
| Other configuration files | Updated various Symfony and third-party config files for improved consistency and routing. | 
Comments suppressed due to low confidence (2)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
https://next-app.activecollab.com/108877/my-work?modal=Task-224038-533