Skip to content

Conversation

@tijsverkoyen
Copy link
Member

@tijsverkoyen tijsverkoyen requested a review from Copilot June 13, 2025 09:48

This comment was marked as outdated.

This comment was marked as outdated.

@tijsverkoyen tijsverkoyen requested a review from Copilot June 19, 2025 15:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to improve and modernize various aspects of the codebase by removing legacy configurations, updating dependency injection and routing conventions, and reworking front-end asset management. Key changes include the removal of the legacy webpack.config.js, extensive renaming of routes and message properties for consistency, and updates to configuration files and asset imports.

Reviewed Changes

Copilot reviewed 95 out of 106 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
webpack.config.js Removed legacy webpack configuration in favor of Symfony’s built-in asset management.
translations/messages+intl-icu.nl.yaml Updated/added translation strings (note potential spelling issue in one phrase).
Multiple Controller, Handler, Message, and Form files Converted method-based user accessors to public readonly property usage and updated DI.
package.json Removed the file, indicating a shift away from npm-managed assets to alternate approaches.
Other configuration files Updated various Symfony and third-party config files for improved consistency and routing.
Comments suppressed due to low confidence (2)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@tijsverkoyen tijsverkoyen changed the title Draft: 362 improve code 362 improve code Jul 15, 2025
@tijsverkoyen tijsverkoyen merged commit b91da0d into main Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants