Issue 299 fixes#300
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sumn2u
force-pushed
the
issue-299-fixes
branch
from
fe9b3a0 to
1d75cc3
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses typo and grammar corrections in the file system documentation, fixing issue #299. The changes improve readability and accuracy of comments and documentation text.
- Corrected spelling errors in comments and console output messages
- Fixed grammatical issues and improved clarity of explanations
- Updated synchronous writeFile example to remove incorrect callback parameter
| fs.writeFileSync("test.txt","mahima is good girl",() => { | ||
| console.log("This is sync: intentionally process is blocked ") | ||
| }) | ||
| fs.writeFileSync("test.txt","mahima is good girl", 'utf8') |
There was a problem hiding this comment.
The fs.writeFileSync function signature is incorrect. The encoding parameter should be passed as part of an options object: fs.writeFileSync("test.txt", "mahima is good girl", { encoding: 'utf8' }) or as the third parameter without quotes: fs.writeFileSync("test.txt", "mahima is good girl", 'utf8')
Collaborator
|
Looks great, merging now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typo and grammer fixes. Fixes #299