Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Maximum Table Size test #107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

314eter
Copy link

@314eter 314eter commented Jul 4, 2019

As discussed in #78, section 4.2 can be interpreted in different ways. But even if you interpret it in the most restrictive way (all table size updates MUST occur at the beginning of a header block), it's only a MUST for the encoder. It says nowhere that the decoder "MUST treat this as a decoding error", which is what the test is checking.

So I don't think there's anything wrong with a decoder that accepts table size updates in the middle of a header block, because it's still perfectly compatible with encoders that follow the other interpretation. For encoders, it's probably safer to be more strict in order to be compatible with all decoders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant