Update ContactsStore.php #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avatar URLs should only be added to NC users, not contacts in the address book. This change checks to see if the contact is a NC user and THEN adds an avatar. Signed-off-by: summersab <arthur.summers@gmail.com>
|
Hi, I fear you created the PR at the wrong location... It must be created here: https://github.com/nextcloud/server/compare |
summersab
pushed a commit
that referenced
this pull request
Jan 24, 2023
add documentation preview_ffmpeg_path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: summersab arthur.summers@gmail.com
[Bug]: Contacts in NC 25 have broken avatar images; user avatars work fine. nextcloud/server#35582
Broken image display for address book contacts in drop down menu nextcloud/contacts#3078
Summary
Avatar URLs should only be added to NC users, not contacts in the address book. As a result, contacts in the address book have broken avatars in the contacts search in the top menu bar. This change checks to see if the contact is a NC user and THEN adds an avatar.
TODO
Checklist