Skip to content

fix(picker): Make highlighted disabled text blue #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

mst101
Copy link
Contributor

@mst101 mst101 commented Dec 16, 2020

@MrWook - An easy one!

I noticed that the text colour of highlighted cells remains dark blue even when the cells are disabled - and includeDisabled: true is added to the highlighted config. The muted text also wasn't quite right. You'll see what I mean with the following:

<Datepicker
  placeholder="Select Date"
  :inline="true"
  :disabled-dates="{
    customPredictor: (date) => {
      return date.getDate() % 3 === 0
    },
  }"
  :highlighted="{
    days: [0, 1, 2, 3],
    includeDisabled: true,
  }"
/>

Before:
before

After:
after

@MrWook MrWook added the bug Something isn't working label Dec 16, 2020
@MrWook MrWook merged commit feb32b1 into sumcumo:master Dec 16, 2020
@mst101 mst101 deleted the fix/highlighted-disabled-text branch December 16, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants