Fix: bootstrap & CLI entrypoint; add __main__ for python -m jarviscli#1271
Open
lrsierra wants to merge 3 commits intosukeesh:masterfrom
Open
Fix: bootstrap & CLI entrypoint; add __main__ for python -m jarviscli#1271lrsierra wants to merge 3 commits intosukeesh:masterfrom
lrsierra wants to merge 3 commits intosukeesh:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
python -m jarviscliwork out of the box by adding a proper package entrypoint. Also add a small bootstrap test to guard this behavior going forward.What Changed
jarviscli/__main__.pysopython -m jarvisclistarts Jarvis by callingJarvis().start()and then entering the command loop.jarviscli/tests/test_bootstrap_entrypoint.pyverifies the module exposes amain()and that calling it triggersJarvis.start()(mocked).No functional changes to plugins; this only addresses startup/bootstrapping.
Why
On a fresh clone,
python -m jarvisclifails because the package has no__main__.py. Providing a standard entrypoint matches the README’s “Run Jarvis from anywhere,” reduces confusion for new contributors, and aligns with Python packaging conventions.How to Test
From repo root: