Open
Conversation
Created a password generator API plugin.
ceramey1997
suggested changes
Aug 13, 2023
| import requests | ||
|
|
||
| @plugin("generate_password") | ||
|
|
| else: | ||
| exclude_numbers = False | ||
|
|
||
| inp = bool(jarvis.input("Would you like to exclude special characters? (Y/N) : ")) |
Contributor
There was a problem hiding this comment.
I'm fairly certain this would always evaluate to true as any string is a truthy value.
|
|
||
| def generate_password(jarvis, s): | ||
| length = int(jarvis.input("Desire password length: ")) | ||
| inp = str(jarvis.input("Would you like to exclude numbers? (Y/N) : ")) |
Contributor
There was a problem hiding this comment.
casting to a str here is un-necessary, by default an input return type is str.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a password generator API plugin. Takes in input on length and Y/N for numbers and special character inclusion.
This addresses issue #1109