Skip to content

Conversation

@mjeammet
Copy link
Member

@mjeammet mjeammet commented Jun 3, 2025

We packaged Docs to be deployed in two clicks on Yunohost <3

@mjeammet mjeammet marked this pull request as ready for review June 3, 2025 14:13
Copy link

@fflorent fflorent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your work! Here are few remarks from my side (don't hesitate to tell me when you don't agree with them).

@virgile-dev
Copy link
Collaborator

virgile-dev commented Jun 6, 2025

@mjeammet @fflorent this needs a review to be merged

@virgile-dev virgile-dev requested a review from fflorent June 6, 2025 18:38
@fflorent
Copy link

fflorent commented Jun 6, 2025

@virgile-dev How urgent is it?

@virgile-dev
Copy link
Collaborator

It's not but I guess we'll forget when this week is over

@mjeammet
Copy link
Member Author

mjeammet commented Jun 6, 2025

I'll rebase !

@fflorent
Copy link

fflorent commented Jun 6, 2025

@mjeammet Could you also include the video? 🙏

@fflorent
Copy link

fflorent commented Jun 6, 2025

@virgile-dev The culprit for the non-passing CI are these lines:

# 1) Block any README.md immediately
if [[ "$f" == *README.md ]]; then
echo "❌ PR modifies a README file: $f"
exit 1
fi

Seems a bit weird as other PRs didn't have this workflow run.

Any way, it sounds like you can bypass it?

@mjeammet
Copy link
Member Author

mjeammet commented Jun 6, 2025

I rebased but it's still borked. Can you maybe rerun a workflow @virgile-dev ? Otherwise I'll just open a new PR (on another branch than my main) ?

@mjeammet mjeammet mentioned this pull request Jun 6, 2025
@virgile-dev virgile-dev closed this Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants