♿(frontend) make html export accessible to screen reader users #1743
+346
−177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ovgodd
force-pushed
the
fix/a11y-html
branch
from
f8e43c1 to
49fd980
Compare
|
Size Change: -1 B (0%) Total Size: 4.15 MB
|
adjusted structure and semantics to ensure proper sr interpretation Signed-off-by: Cyril <c.gromoff@gmail.com>
Ovgodd
force-pushed
the
fix/a11y-html
branch
from
49fd980 to
10b5eb3
Compare
AntoLC
reviewed
Dec 18, 2025
Collaborator
There was a problem hiding this comment.
Can we add all the utility function about the html feature in a separate file like utils-html.ts ?
| * - We work directly on the parsed Document so modifications are reflected before we zip files. | ||
| * - We keep the editor inner structure but upgrade the key block types to native elements. | ||
| */ | ||
| export const improveHtmlAccessibility = ( |
Collaborator
There was a problem hiding this comment.
I think we should unit test this function, I can see there is some unexpected behavior around the li tag:
Here you can get a pre-made template with lot of blocks: https://www.blocknotejs.org/examples/interoperability/converting-blocks-to-pdf
Comment on lines
360
to
367
| const quoteBlocks = Array.from( | ||
| body.querySelectorAll<HTMLElement>("[data-content-type='quote']"), | ||
| ); | ||
| quoteBlocks.forEach((block) => { | ||
| const quote = parsedDocument.createElement('blockquote'); | ||
| quote.innerHTML = block.innerHTML; | ||
| block.replaceWith(quote); | ||
| }); |
Collaborator
There was a problem hiding this comment.
We have a recession on that:
Before:
After:
| - 🌐(backend) internationalize demo #1644 | ||
| - ♿(frontend) improve accessibility: | ||
| - ♿️Improve keyboard accessibility for the document tree #1681 | ||
| - ♿(frontend) make html export accessible to screen reader users #1743 |
Collaborator
There was a problem hiding this comment.
When rebase, it will have to go under "Unreleased".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Ensure that the HTML export is accessible to screen reader users by improving
its semantic structure and navigability.
Proposal
Refactor the HTML export output to follow accessibility best practices:
proper use of landmarks, headings, and roles to provide clear structure and
context for assistive technologies.