Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partition names should be prefixed by "p" for NVMe #43

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

uraza
Copy link
Contributor

@uraza uraza commented Apr 11, 2023

Hi.

My setup involves a NVMe drive and I found out that the script did not set the partition names correctly in that case
Indeed, for NVMe drives, the partition names should be "p1" and "p2" instead of "1" and "2".

I do not know if the change that I did is very reliable though
have seen it done like this in some other script, but perhaps not all drives have their names laid out like this.

I will let you judge whether this is good enough or if the script should have an extra configuration parameter set manually by the user.

Anyway, thanks for developing this script, I did a Void Linux installation with it and it is really a life changer!

@suikan4github suikan4github self-assigned this Apr 12, 2023
@suikan4github suikan4github added the bug Something isn't working label Apr 12, 2023
@suikan4github
Copy link
Owner

Thank you very much for your pull request.

By fast look, your patch is promising. Let me check with my VM and will be back with the result.

@suikan4github
Copy link
Owner

This pull request is tested with the following environment :

  • Ubuntu 22.04 LTS.
  • VMWare Workstation
    • nvme drive
    • scsi drive

The result was OK.

The code is well-formed and with enough comments. Easy to read. The logic of the entire modification is appropriate.

OK to merge and release as a bug-fix version.

@suikan4github suikan4github merged commit 851bfe6 into suikan4github:main Apr 14, 2023
@suikan4github
Copy link
Owner

Hi Uraza

Thank you very much for your contribution. I have reviewed your code and tested your pull request on my VMs. The code is simple, logical, and easy to read. And the modification works fine for both NVME and SCSI.

I have just released a minor revision V1.3.1 by merging your contribution.

Again, thank you very much for contributing to improving this software.

Seiichi

suikan4github added a commit that referenced this pull request Apr 14, 2023
Merget the Issue #43 pull request.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants