Partition names should be prefixed by "p" for NVMe #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
My setup involves a NVMe drive and I found out that the script did not set the partition names correctly in that case
Indeed, for NVMe drives, the partition names should be "p1" and "p2" instead of "1" and "2".
I do not know if the change that I did is very reliable though
have seen it done like this in some other script, but perhaps not all drives have their names laid out like this.
I will let you judge whether this is good enough or if the script should have an extra configuration parameter set manually by the user.
Anyway, thanks for developing this script, I did a Void Linux installation with it and it is really a life changer!