Skip to content

Conversation

@mikeygee
Copy link

Hey there, really cool project you got here. I used your code for an online book project and noticed an issue where clicking above or below the pages within the canvas activated a page turn. This is a fix for that issue, as well as a few extra functions to support navigating the book. Also put in a couple of visual options for adding a shadow effect and clearing out the plain background color if using a non-solid background. Just thought I'd do a pull request in case you find it useful.

@suhinini
Copy link
Owner

Hey, this is fantastic!

Now I don't have time to work on it, so could you please merge your changes
to Codeplex code? I can give you admin access.

And please give me a link for this project - it would be awesome to see
jPageFlipper in real world.

Thanks,
Ivan

On Tue, Jan 24, 2012 at 10:30 AM, Mikey Gee <
reply@reply.github.com

wrote:

Hey there, really cool project you got here. I used your code for an
online book project and noticed an issue where clicking above or below the
pages within the canvas activated a page turn. This is a fix for that
issue, as well as a few extra functions to support navigating the book.
Also put in a couple of visual options for adding a shadow effect and
clearing out the plain background color if using a non-solid background.
Just thought I'd do a pull request in case you find it useful.

You can merge this Pull Request by running:

git pull https://github.com/mikeygee/jPageFlipper master

Or you can view, comment on it, or merge it online at:

#2

-- Commit Summary --

  • Bug fix for clicking outside of page, add functions for navigation
  • typo in comment

-- File Changes --

M jquery.pageFlipper.js (48)

-- Patch Links --

https://github.com/suhinini/jPageFlipper/pull/2.patch
https://github.com/suhinini/jPageFlipper/pull/2.diff


Reply to this email directly or view it on GitHub:
#2

@mikeygee
Copy link
Author

Hey, I don't have an account with Codeplex, and I don't really want to sign up for one. I use github for everything. It's only one file, so should be easy to incorporate in whatever system you're using.

Here is a link to the project as an example of how I used it: http://511contracosta.org/hydrogencars/

Thanks for the great work. It came in very handy.

@suhinini
Copy link
Owner

Ah, ok. I'll merge these changes in, thanks!

Btw, nice website!

On Wed, Jan 25, 2012 at 8:53 AM, Mikey Gee <
reply@reply.github.com

wrote:

Hey, I don't have an account with Codeplex, and I don't really want to
sign up for one. I use github for everything. It's only one file, so should
be easy to incorporate in whatever system you're using.

Here is a link to the project as an example of how I used it:
http://511contracosta.org/hydrogencars/

Thanks for the great work. It came in very handy.


Reply to this email directly or view it on GitHub:
#2 (comment)

@suhinini
Copy link
Owner

Hi Mikey

I've just moved your changes to Codeplex. Thanks again for supporting the
project!

Ivan

@mikeygee
Copy link
Author

Sure thing, glad I could help.

On Fri, Feb 17, 2012 at 12:12 PM, suhinini <
reply@reply.github.com

wrote:

Hi Mikey

I've just moved your changes to Codeplex. Thanks again for supporting the
project!

Ivan


Reply to this email directly or view it on GitHub:
#2 (comment)

@kalburgishraddha
Copy link

I want to have this bookview as horizontal.have to update updateHandlePositions() function.anyone tried this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants