Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Go! Princess Precure and Spring Carnival #66

Merged
merged 2 commits into from
Feb 22, 2015
Merged

Support Go! Princess Precure and Spring Carnival #66

merged 2 commits into from
Feb 22, 2015

Conversation

sue445
Copy link
Owner

@sue445 sue445 commented Dec 31, 2014

TODO

  • cast_name
  • color
  • cure_flora created_date
  • cure_mermaid created_date
  • cure_twinkle created_date

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling b7b7e65 on feature/go_princess_precure_0.2.0 into 5ddb04d on master.

sue445
sue445 reviewed Jan 15, 2015
View reviewed changes
config/girls/012_go_princess.yml
attack_messages:
- |
transform_calls:
cure_twincle: &cure_twincle
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • x twincle
  • o twinkle

@sue445 sue445 force-pushed the feature/go_princess_precure_0.2.0 branch 2 times, most recently from c408b27 to 9ab5eef Compare January 18, 2015 08:22
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 9ab5eef on feature/go_princess_precure_0.2.0 into 5424151 on master.

@sue445 sue445 mentioned this pull request Jan 21, 2015
Closed
@sue445 sue445 force-pushed the feature/go_princess_precure_0.2.0 branch from 9ab5eef to dabebc5 Compare January 26, 2015 14:04
@sue445 sue445 force-pushed the feature/go_princess_precure_0.2.0 branch 2 times, most recently from ab32434 to faa6b21 Compare February 1, 2015 01:05
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.09% when pulling faa6b21 on feature/go_princess_precure_0.2.0 into 9d75e82 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.09% when pulling f55adb2 on feature/go_princess_precure_0.2.0 into 9d75e82 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.09% when pulling f55adb2 on feature/go_princess_precure_0.2.0 into 9d75e82 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.09% when pulling 05852fa on feature/go_princess_precure_0.2.0 into 9d75e82 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.09% when pulling 05852fa on feature/go_princess_precure_0.2.0 into 9d75e82 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.09% when pulling 4021c70 on feature/go_princess_precure_0.2.0 into 9d75e82 on master.

@sue445 sue445 force-pushed the feature/go_princess_precure_0.2.0 branch from 4021c70 to 608b358 Compare February 2, 2015 14:47
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.09% when pulling 608b358 on feature/go_princess_precure_0.2.0 into 9d75e82 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.09% when pulling f3cec86 on feature/go_princess_precure_0.2.0 into 9d75e82 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.09% when pulling 96a429b on feature/go_princess_precure_0.2.0 into 9d75e82 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.09% when pulling 96a429b on feature/go_princess_precure_0.2.0 into 9d75e82 on master.

@sue445 sue445 force-pushed the feature/go_princess_precure_0.2.0 branch from 96a429b to ebc53a0 Compare February 22, 2015 00:13
houndci-bot
houndci-bot reviewed Feb 22, 2015
View reviewed changes
spec/core_spec.rb
[:new_stage2, 32],
[:ns3 , 36],
[:new_stage3, 36],
["2009-03-20" , 14],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary spacing detected.

houndci-bot
houndci-bot reviewed Feb 22, 2015
View reviewed changes
spec/core_spec.rb
[:ns1 , 28],
[:new_stage , 28],
[:new_stage1, 28],
[:ns2 , 32],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary spacing detected.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.09% when pulling ebc53a0 on feature/go_princess_precure_0.2.0 into 9d75e82 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.09% when pulling ebc53a0 on feature/go_princess_precure_0.2.0 into 9d75e82 on master.

@sue445 sue445 force-pushed the feature/go_princess_precure_0.2.0 branch from ebc53a0 to 431de4f Compare February 22, 2015 00:16
houndci-bot
houndci-bot reviewed Feb 22, 2015
View reviewed changes
spec/core_spec.rb

[:ns, 28],
[:ns1, 28],
[:new_stage, 28],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary spacing detected.

@sue445
Add go! princess precure, spring_carnival
7779020 
Add example code for Go! princess precure
@sue445 sue445 force-pushed the feature/go_princess_precure_0.2.0 branch from 431de4f to 7779020 Compare February 22, 2015 00:17
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.09% when pulling 7779020 on feature/go_princess_precure_0.2.0 into 9d75e82 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.09% when pulling 7779020 on feature/go_princess_precure_0.2.0 into 9d75e82 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.09% when pulling 7779020 on feature/go_princess_precure_0.2.0 into 9d75e82 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.09% when pulling 7779020 on feature/go_princess_precure_0.2.0 into 9d75e82 on master.

@sue445 sue445 changed the title [WIP] Support Go! Princess Precure and Spring Carnival Support Go! Princess Precure and Spring Carnival Feb 22, 2015
sue445 added a commit that referenced this pull request Feb 22, 2015
@sue445
Merge pull request #66 from sue445/feature/go_princess_precure_0.2.0
163d38c 
Support Go! Princess Precure and Spring Carnival
@sue445 sue445 merged commit 163d38c into master Feb 22, 2015
@sue445 sue445 deleted the feature/go_princess_precure_0.2.0 branch February 22, 2015 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sue445 @coveralls @houndci-bot