Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add arg to all stars #16

Merged
merged 10 commits into from
Jan 4, 2014
Merged

Feature/add arg to all stars #16

merged 10 commits into from
Jan 4, 2014

Conversation

sue445
Copy link
Owner

@sue445 sue445 commented Jan 4, 2014

Precure.all_stars に日付やシンボルを渡せるようにして、その時点でのオールスターズを取得できるようにしてみました。

初登場日が合ってるか辺りを重点的に確認お願いしたいです。(ミューズ、ムーンライトは正式加入した日付)

for example

Precure.all_stars("2013-10-26").count
#=> 33
Precure.all_stars(:dx).count
#=> 14
Precure.all_stars(:dx2).count
#=> 17
Precure.all_stars(:dx3).count
#=> 21
Precure.all_stars(:new_stage).count
#=> 28
Precure.all_stars(:new_stage2).count
#=> 32

@ghost ghost assigned kaosf Jan 4, 2014
@coveralls
Copy link

Coverage Status

Coverage decreased (-33.37%) when pulling 43967a2 on feature/add_arg_to_all_stars into 43789c3 on master.

@sue445
Copy link
Owner Author

sue445 commented Jan 4, 2014

@kaosf thx!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) when pulling 38da393 on feature/add_arg_to_all_stars into 43789c3 on master.

kaosf added a commit that referenced this pull request Jan 4, 2014
@kaosf kaosf merged commit 4d2fd96 into master Jan 4, 2014
@kaosf kaosf deleted the feature/add_arg_to_all_stars branch January 4, 2014 15:40
@sue445
Copy link
Owner Author

sue445 commented Jan 4, 2014

👍

sue445 added a commit that referenced this pull request Jan 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants