Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability for L1 to claim L2 royalties #2

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

tomwade
Copy link

@tomwade tomwade commented Aug 7, 2024

This adds a call to the L1 Bridge so that contracts that support the IERC2981 interface can claim royalties to a specific L2 recipient.

One short fall of this implementation is that we only look at tokenId 0 to validate the msg.sender. This means that anyone with access to royalties of the zero token could claim royalties across the whole project. I don't believe there are many instances in which this would be worrying for an NFT project though.

Question:

  • Does this cover enough royalty implementations? This adopts the standard, but I don't know if there are any mainstream projects that would need a caveat (like Punks for transfers)
  • Sorry there are a number of other QoL updates in this PR as well, I should have split those out

@tomwade tomwade self-assigned this Aug 7, 2024
@tomwade tomwade requested a review from sudo-owen August 7, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant