fix(renderer): handle inserting out of order parts #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we're not rerendering, relative timestamps don't make sense as they don't update.
Owner
|
Great. It was a lot easier than I anticipated. Thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support sending multiple messages, the main thing that we needed to support was inserting parts not at the end. I didn't need to build a queue of outgoing messages because we can just send them to Opencode as we get them.
This PR also includes not using relative timestamps as they don't make sense when we're not re-rendering. The time should be formatted the way the Opencode TUI does it.
I've tested simultaneous messages a bit but it could definitely use another set of eyes.