fix(topbar): fix spacing #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an off by one for the mode string. I tried cleaning the code up to make it easier to think about and, hopefully, extend, if needed.
Owner
|
Nice catch. I also start to think that the toolbar is getting a little bit out of control. I think that the model should be close to the input window in the future. The guard icon could also be moved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an off by one for the mode string.
Before:
After:
No guard, no truncation, plan
No guard, truncation, plan
No guard, truncation, build
Guard, no truncation, plan
Guard, truncation, plan
Guard, truncation, build
As a design choice, I extend the top bar all the way to the left and right (rather than leaving one empty space on both sides. Given how much we want to show in that area, I figured it was best to have as much room for guard, description, model, and mode
I also tried cleaning the code up to make it easier to think about and, hopefully, extend, if needed.
Not for this request, but I also wonder if the guard icon would make more sense to display in the input area? Maybe something for your context bar at some point.