fix(history): error when windows closed #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle the case when the history dialog is open and an item is selected before the input/output windows are created. Fixes sudo-tee#141
Collaborator
Author
|
Even with the async changes, I think it's safe to just set windows right after because any yields would come after the |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the history picker would error when selecting an item if the input/output windows were not already open. The fix ensures that after opening windows, the local windows variable is updated to reference the newly created windows.
Key Changes
- Updates the local
windowsvariable after callingcore.open()to ensure it references the newly created windows instate.windows
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
Thanks for the quick fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle the case when the history dialog is open and an item is selected before the input/output windows are created.
Fixes #141