Skip to content

Conversation

@sudo-tee
Copy link
Owner

This makes the panel closer to opencode tui.

image

Model is hiddent when loading for the spinner

image

This makes the panel closer to opencode tui.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the UI layout by moving the model and mode display from the topbar to the footer, and moving token count and cost information to the topbar. This makes the interface more consistent with the opencode TUI design.

Key changes:

  • Topbar now displays session title and token/cost information instead of model/mode
  • Footer now displays model (when not running) and mode with visual highlighting
  • Footer text layout uses a new flexible left/right segment system with proper padding

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
lua/opencode/ui/topbar.lua Refactored to display token count and cost info; removed model/mode display and related highlighting logic
lua/opencode/ui/footer.lua Added model and mode display with highlights; introduced new layout system with left/right segments and window resize handling

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

sudo-tee and others added 2 commits November 11, 2025 15:56
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Repository owner deleted a comment from Copilot AI Nov 11, 2025
@sudo-tee sudo-tee marked this pull request as ready for review November 11, 2025 21:04
Repository owner deleted a comment from Copilot AI Nov 11, 2025
@cameronr
Copy link
Collaborator

Ooh, I'll take a look today!

@cameronr
Copy link
Collaborator

cameronr commented Nov 11, 2025

I think it's a nice improvement. The only thing that's kind of been bothering me is the lack of spacing between the footer and the last line of the assistant response (it feels particularly off because there's more spacing below the footer because the window separator takes up a whole row). This change makes that conflict more noticeable because now there's always something in left part of the footer (instead of that only being where the thinking message is). It's especially noticeable when there's an error or anything with full height characters:

Screenshot 2025-11-11 at 14 34 54

I seem to always suggest right aligning, but maybe that's also an option here? Here's what it looks like:

Screenshot 2025-11-11 at 14 36 06

There's less likely to be output text on right so the spacing issue doesn't have as much visual impact (at least for me). Opencode TUI does also have the model and mode together on the right...

@sudo-tee
Copy link
Owner Author

sudo-tee commented Nov 11, 2025

You are right. I have been trying to add padding to the bottom for a while... But couldn't get it to work in a reliable way..

I tried phantom lines. scroll off on the buffer. And many other things.

If you have an idea on how to do it let me know.

The issue having it to the right. Is that it looks off when the cancel message is there. Maybe hiding it would make sense.

@cameronr
Copy link
Collaborator

cameronr commented Nov 11, 2025

Yeah, in my quick right align test, I hide the model when there's a request in process:

Screenshot 2025-11-11 at 15 06 13

Haha, I also tried a number of things that didn't work. The only thing I ever got working well enough was to add an extra newline (that got removed when inserting new parts at the end). I wasn't sure if I liked it better or not. I'll push a branch for you to try out, if you want.

@sudo-tee
Copy link
Owner Author

Ok I will then align it to the right. It looks fine to me

@sudo-tee sudo-tee merged commit 90fc43d into main Nov 12, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants