fix(core): create session if no current and no last #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The and_then/catch handlers didn't really make sense and we don't need them anyway.
cameronr
force-pushed
the
fix/server-job-cleanup
branch
from
90e22b3 to
d67dc63
Compare
If we're not starting a new session, we don't have a current session and we don't have a last session, we have to create a new session. Without a session, submitting prompts fails silently.
cameronr
force-pushed
the
fix/server-job-cleanup
branch
from
d67dc63 to
7e5b03c
Compare
cameronr
changed the title
Collaborator
Author
|
@sudo-tee I think this is now probably urgent. We weren't creating a session if you had no active_session and no previous sessions. We haven't noticed because we all have sessions but a new user (or working in a new project) will fail silently when you submit a response without this fix. |
Owner
|
Very nice fix. I did a quick review and it all looks fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we're not starting a new session, we don't have a current session and
we don't have a last session, we have to create a new session.
Without a session, submitting prompts fails silently.
Clean up the promise chains in server_job (they didn't really make sense since we don't return them and we don't need them anyway)
Also more type / diagnostic cleanup