feat(timeline-picker): implement basic timeline picker

[sudo-tee]

This implement a simple timeline pcker similar to the one found in opencode tui

[cameronr]

Oh nice! I'm happy to review when it's ready

[sudo-tee]

@cameronr

If you want to have a look, it's almost ready

[cameronr]

Great, I'll take a look today

[cameronr]

Had a few mins and tried to play around with it but ran into some early errors:

1. Getting an error when typing in the session picker (using snacks). I assume related to the picker_utils unification?

Unhandled async error:
...nvim/lazy/snacks.nvim/lua/snacks/picker/core/matcher.lua:524: attempt to index local 'str' (a nil value)

2. Error when I try to open the timeline:

E5108: Error executing lua: ...im-dev/opencode.nvim/lua/opencode/ui/timeline_picker.lua:4: module 'lua.opencode.config' not found:

Removing the "lua." does let me open the picker. I'll take a closer look but wanted to share those issues in case they were already on your radar.

[cameronr]

Do you think picker_util can get the size of the picker window and right align the dates across all of the picker plugins?

[cameronr]

It's coming along really nicely!

My only suggestion is that we should do some more work on how the pickers format their text:

1. Dates should be right aligned consistently across the picker providers
2. I wonder if there's an opportunity for a more condensed date format, maybe it's "Oct 05 14:23" if it's this year, and "2024-10-05 14:23" if not?

[sudo-tee]

Had a few mins and tried to play around with it but ran into some early errors:

1. Getting an error when typing in the session picker (using snacks). I assume related to the picker_utils unification?

Unhandled async error:
...nvim/lazy/snacks.nvim/lua/snacks/picker/core/matcher.lua:524: attempt to index local 'str' (a nil value)

2. Error when I try to open the timeline:

E5108: Error executing lua: ...im-dev/opencode.nvim/lua/opencode/ui/timeline_picker.lua:4: module 'lua.opencode.config' not found:

Removing the "lua." does let me open the picker. I'll take a closer look but wanted to share those issues in case they were already on your radar.

I will soon have a refactored picker that both sessions and timeline can use. It will be much easier to create new ones

[sudo-tee]

It's coming along really nicely!

My only suggestion is that we should do some more work on how the pickers format their text:

1. Dates should be right aligned consistently across the picker providers
2. I wonder if there's an opportunity for a more condensed date format, maybe it's "Oct 05 14:23" if it's this year, and "2024-10-05 14:23" if not?

Great idea.

For the alignment. I need to find a way to get the picker width.

[sudo-tee]

It's coming along really nicely!

My only suggestion is that we should do some more work on how the pickers format their text:

1. Dates should be right aligned consistently across the picker providers
2. I wonder if there's an opportunity for a more condensed date format, maybe it's "Oct 05 14:23" if it's this year, and "2024-10-05 14:23" if not?

@cameronr

I did some work on having the dates align on all pickers.

Unfortunately some pickers construct their list before showing the window so getting the with was not possible.

I ended up fixing the with of the picker instead with a config, It works pretty well with some edges cases where telescope and fzf have somme padding in their default theme. I added a padding offset for theeses pickers. It should be good enough.

[sudo-tee]

Telescope

Snacks

FZF

mini.pick

[cameronr]

With my font settings, the times/dates are completely hidden with snacks (but the others are fine):

For snacks, the width is available in the format function, so instead wrapping format_fn and hardcoding opts.width, we could leave format function as is and then for pickers that have a width available, they can use that:

    format = function(item, snacks_picker)
      return opts.format_fn(item, snacks_picker.layout.width):to_formatted_text()
    end,

For other pickers, they could just pass opts.width

I made that change and here's what it looks like (other pickers are unchanged):

I made two other changes:

• fixed snacks typing (it requires item.text to be set)
• used the actual time to set time_width. I know that means that the ... transition will happen differently for short times vs long times but I think that's actually more desirable (and it shouldn't be jarring because it'll be one time transition from short dates to long dates).

Hopefully those changes are ok!

[cameronr]

Oh shoot, I just saw your update to set the snacks layout widths. I'll undo the the snacks width changes.

[cameronr]

Ok, so now my changes are just fixing snacks matching and using the actual time for width calculation.

Everything else looks good. Really nicely done!

[sudo-tee]

Thanks for your fixes.

I will merge this pretty soon