Added fixes mentioned in previous PR

[z3t0]

This is still Arduino 1.0 but is labelled as latest for now (will be renamed later)

[sudar]

I see that for library keywords it is still using syn keyword and is not grouping them to use a different group. Did you fix it?

On second thought I think it's not a big deal. If you are not working on it, then I think I can go merge this, after making some changes to the credits and readme files.

[z3t0]

Oh sorry it was a misunderstanding I can easily change that, I thought you
wanted to change the part after keyword, like arduinoConstant to
arduinoLibraryConstant.
I'll do that soon and make another PR

[z3t0]

Will fix library keyword and make a new PR

[sudar]

Oops.. sorry for the confusion.

As I said it's fine if you don't want to change it.

[z3t0]

No problem, I definitely want to change it I just misunderstood what you
meant. I'll get it done asap

On Thu, Feb 26, 2015 at 9:33 AM, Sudar Muthu notifications@github.com
wrote:

Oops.. sorry for the confusion.

As I said it's fine if you don't want to change it.

—
Reply to this email directly or view it on GitHub
#8 (comment)
.

Thanks,
Rafi Khan

[z3t0]

I am not sure what you mean by changing 'keyword' to something like 'libraryKeyword'
Because according to the wiki, keyword is defined by vim and the only one of its type, the others being match and region which is totally different.

I could find any examples of how to disable parts of a syntax file... Probably something to add to the TODO of the vim plugin, which should be capable of partial highlighting.

In this case we should just merge this since we cannot achieve partial highlighting without making a plugin (I think). So I will begin work on the plugin and keep you updated. For now I am going to try and make it duplicate the functionality of this syntax file, once there we can expand and make it an amazing plugin.

[z3t0]

Please merge this.

[sudar]

As I said over Google Hangout, ignore my previous comment.

Give me a day or two, I will just test this once in my setup and will merge it.

Thanks for all the effort you have put in this project.

[z3t0]

OK sounds good!

[sudar]

@z3t0 Thanks. I just merged it.

[z3t0]

@sudar Happy I could help!

[Jaidan]

This PR appears to have been completely borked? Just used and I'm getting syntax errors starting on line 265 every time I load an .ino file. I don't know jack about creating syntax files, but it appears the lines should all be at least: syn foo bar where foo is a group and bar is at least one token to be defined. It seems like the grouping got nuked.

[Jaidan]

This is clearly broken =(

[sudar]

DAMN!! I am reverting it.

Thanks @Jaidan for reporting it.

@z3t0 Can you take a look at it?